Skip to content

chore: drop scala_legacy and MainGenericRunner #24244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

chore: drop scala_legacy and MainGenericRunner #24244

merged 1 commit into from
Oct 27, 2025
+15 −634

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Oct 23, 2025 •
edited
Loading

With everything that is happening for 3.8.0, I believe it is now time to remove the old runner infrastructure and the scala_legacy script too. scala-cli has been shipped with every release of Scala since 3.5.0.

In preparation for #24243

@hamzaremmal hamzaremmal self-assigned this Oct 23, 2025
@som-snytt
Copy link
Contributor

som-snytt commented Oct 23, 2025 •
edited
Loading

bin/scalaQ is MainGenericRunner, which I need every time the test rig is broken or too slow. How does everyone else cope?

Should add, avoiding publishLocal. This is for a cycle in a few seconds.

@Gedochao
Copy link
Contributor

Gedochao commented Oct 24, 2025

@som-snytt it is rather inevitable that we have to do this, as the REPL is being extracted to a separate artifact in #24243.
scala_legacy has been deprecated for a while now, and it's been the plan to have it removed in 3.10.
This now puts it up for discussion whether we should do it now.
I think it may be worth it, so that we have the separate REPL with all its benefits done for 3.9 LTS (plus the necessary tooling changes would happen in 3.8, which requires tooling adjustments for the standard library and other things already).

@Gedochao Gedochao added the stat:needs decision Some aspects of this issue need a decision from the maintainance team. label Oct 24, 2025
@Gedochao
Copy link
Contributor

Gedochao commented Oct 24, 2025

https://github.com/coursier/apps/blob/main/apps/resources/scala3.json
we'll need to update coursier/apps when we do this, BTW.

@hamzaremmal
Copy link
Member Author

hamzaremmal commented Oct 24, 2025

And https://github.com/coursier/apps/blob/main/apps/resources/scala3-repl.json too

@Gedochao Gedochao removed the stat:needs decision Some aspects of this issue need a decision from the maintainance team. label Oct 27, 2025
@Gedochao
Copy link
Contributor

Gedochao commented Oct 27, 2025

scala_legacy has been deprecated for a while now, and it's been the plan to have it removed in 3.10. This now puts it up for discussion whether we should do it now.

It seems we're doing it in 3.8.0

@hamzaremmal hamzaremmal marked this pull request as ready for review October 27, 2025 12:26
@hamzaremmal hamzaremmal requested a review from Gedochao October 27, 2025 12:26
@hamzaremmal hamzaremmal assigned Gedochao and unassigned hamzaremmal Oct 27, 2025
@hamzaremmal hamzaremmal enabled auto-merge October 27, 2025 12:26
@hamzaremmal hamzaremmal merged commit ce57b71 into scala:main Oct 27, 2025
51 checks passed
@hamzaremmal hamzaremmal deleted the remove-old-script branch October 27, 2025 12:36
@Gedochao Gedochao mentioned this pull request Oct 27, 2025
Merged
Gedochao added a commit that referenced this pull request Oct 27, 2025
@Gedochao
Deprecate scala_legacy/MainGenericRunner/scalac -run/`scalac -r…
b4e531e 
…epl` for removal (#24267)

This is a companion PR to #24243 &
#24244
Note: this is meant for the Scala 3.7.4 branch, only.
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees

@Gedochao Gedochao

Labels

None yet

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hamzaremmal @som-snytt @Gedochao @WojciechMazur